diff options
| author | Liu Bo <bo.li.liu@oracle.com> | 2016-09-15 04:19:05 +0200 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2016-09-26 18:08:44 +0200 |
| commit | 02794222c4132ac003e7281fb71f4ec1645ffc87 (patch) | |
| tree | cefd45556357dba00b53425d9ab018da2d8e1a31 /fs/btrfs/extent-tree.c | |
| parent | Btrfs: don't leak reloc root nodes on error (diff) | |
| download | linux-02794222c4132ac003e7281fb71f4ec1645ffc87.tar.xz linux-02794222c4132ac003e7281fb71f4ec1645ffc87.zip | |
Btrfs: kill BUG_ON in run_delayed_tree_ref
In a corrupted btrfs image, we can come across this BUG_ON and
get an unreponsive system, but if we return errors instead,
its caller can handle everything gracefully by aborting the current
transaction.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to '')
| -rw-r--r-- | fs/btrfs/extent-tree.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 73fb91f9d797..3d3b193a396c 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -2352,7 +2352,13 @@ static int run_delayed_tree_ref(struct btrfs_trans_handle *trans, ins.type = BTRFS_EXTENT_ITEM_KEY; } - BUG_ON(node->ref_mod != 1); + if (node->ref_mod != 1) { + btrfs_err(root->fs_info, + "btree block(%llu) has %d references rather than 1: action %d ref_root %llu parent %llu", + node->bytenr, node->ref_mod, node->action, ref_root, + parent); + return -EIO; + } if (node->action == BTRFS_ADD_DELAYED_REF && insert_reserved) { BUG_ON(!extent_op || !extent_op->update_flags); ret = alloc_reserved_tree_block(trans, root, |