diff options
| author | Goldwyn Rodrigues <rgoldwyn@suse.com> | 2019-09-11 18:45:15 +0200 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2019-11-18 12:46:45 +0100 |
| commit | 9cf35f673583ccc9f3e2507498b3079d56614ad3 (patch) | |
| tree | 32eb38a32f613b4aae675b26f08e5c7af0b9e5ba /fs/btrfs/file.c | |
| parent | Linux 5.4-rc8 (diff) | |
| download | linux-9cf35f673583ccc9f3e2507498b3079d56614ad3.tar.xz linux-9cf35f673583ccc9f3e2507498b3079d56614ad3.zip | |
btrfs: simplify inode locking for RWF_NOWAIT
This is similar to 942491c9e6d6 ("xfs: fix AIM7 regression"). Apparently
our current rwsem code doesn't like doing the trylock, then lock for
real scheme. This causes extra contention on the lock and can be
measured eg. by AIM7 benchmark. So change our read/write methods to
just do the trylock for the RWF_NOWAIT case.
Fixes: edf064e7c6fe ("btrfs: nowait aio support")
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
[ update changelog ]
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/file.c')
| -rw-r--r-- | fs/btrfs/file.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 435a502a3226..25ce1b6dbda9 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -1903,9 +1903,10 @@ static ssize_t btrfs_file_write_iter(struct kiocb *iocb, (iocb->ki_flags & IOCB_NOWAIT)) return -EOPNOTSUPP; - if (!inode_trylock(inode)) { - if (iocb->ki_flags & IOCB_NOWAIT) + if (iocb->ki_flags & IOCB_NOWAIT) { + if (!inode_trylock(inode)) return -EAGAIN; + } else { inode_lock(inode); } |