diff options
| author | Josef Bacik <jbacik@fusionio.com> | 2013-06-04 03:39:49 +0200 |
|---|---|---|
| committer | Josef Bacik <jbacik@fusionio.com> | 2013-06-14 17:30:16 +0200 |
| commit | 01cd33674e95296e1647da3534b9aef1e98556b5 (patch) | |
| tree | 2d7f1e1f088c546266a5a7f01782c9374982ac93 /fs/btrfs/inode.c | |
| parent | Btrfs: add some missing iput()'s in btrfs_orphan_cleanup (diff) | |
| download | linux-01cd33674e95296e1647da3534b9aef1e98556b5.tar.xz linux-01cd33674e95296e1647da3534b9aef1e98556b5.zip | |
Btrfs: put our inode if orphan cleanup fails
When we cross into a different subvol when doing a lookup we will run the orhpan
cleanup. If this fails however we do not drop the ref to the inode we were
looking up before we return an error, which leads to busy inodes on umount.
Thanks,
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Diffstat (limited to 'fs/btrfs/inode.c')
| -rw-r--r-- | fs/btrfs/inode.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index c52ceb8c24e0..a2df4690b000 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -4941,8 +4941,10 @@ struct inode *btrfs_lookup_dentry(struct inode *dir, struct dentry *dentry) if (!(inode->i_sb->s_flags & MS_RDONLY)) ret = btrfs_orphan_cleanup(sub_root); up_read(&root->fs_info->cleanup_work_sem); - if (ret) + if (ret) { + iput(inode); inode = ERR_PTR(ret); + } } return inode; |