diff options
author | Zach Brown <zab@redhat.com> | 2013-04-02 23:02:16 +0200 |
---|---|---|
committer | Josef Bacik <jbacik@fusionio.com> | 2013-05-06 21:54:36 +0200 |
commit | d4e3991b9945906528c7abb627d759ea43f53bce (patch) | |
tree | 8ef759bd9b3348528c29bb0433c57eae921d6ad2 /fs/btrfs/ioctl.c | |
parent | btrfs: ignore device open failures in __btrfs_open_devices (diff) | |
download | linux-d4e3991b9945906528c7abb627d759ea43f53bce.tar.xz linux-d4e3991b9945906528c7abb627d759ea43f53bce.zip |
btrfs: abort unlink trans in missed error case
__btrfs_unlink_inode() aborts its transaction when it sees errors after
it removes the directory item. But it missed the case where
btrfs_del_dir_entries_in_log() returns an error. If this happens then
the unlink appears to fail but the items have been removed without
updating the directory size. The directory then has leaked bytes in
i_size and can never be removed.
Adding the missing transaction abort at least makes this failure
consistent with the other failure cases.
I noticed this while reading the code after someone on irc reported
having a directory with i_size but no entries. I tested it by forcing
btrfs_del_dir_entries_in_log() to return -ENOMEM.
Signed-off-by: Zach Brown <zab@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Diffstat (limited to 'fs/btrfs/ioctl.c')
0 files changed, 0 insertions, 0 deletions