diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-05-04 13:38:41 +0200 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2024-05-07 21:31:11 +0200 |
| commit | 0e39c9e524479b85c1b83134df0cfc6e3cb5353a (patch) | |
| tree | 50d66cc4bf741950805fa9014b35192d722224a0 /fs/btrfs/qgroup.c | |
| parent | btrfs: count super block write errors in device instead of tracking folio err... (diff) | |
| download | linux-0e39c9e524479b85c1b83134df0cfc6e3cb5353a.tar.xz linux-0e39c9e524479b85c1b83134df0cfc6e3cb5353a.zip | |
btrfs: qgroup: fix initialization of auto inherit array
The "i++" was accidentally left out so it just sets qgids[0] over and
over.
This can lead to unexpected problems, as the groups[1:] would be all 0,
leading to later find_qgroup_rb() unable to find a qgroup and cause
snapshot creation failure.
Fixes: 5343cd9364ea ("btrfs: qgroup: simple quota auto hierarchy for nested subvolumes")
CC: stable@vger.kernel.org # 6.7+
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/qgroup.c')
| -rw-r--r-- | fs/btrfs/qgroup.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index 1768fc6f232f..eb28141d5c37 100644 --- a/fs/btrfs/qgroup.c +++ b/fs/btrfs/qgroup.c @@ -3123,7 +3123,7 @@ static int qgroup_auto_inherit(struct btrfs_fs_info *fs_info, qgids = res->qgroups; list_for_each_entry(qg_list, &inode_qg->groups, next_group) - qgids[i] = qg_list->group->qgroupid; + qgids[i++] = qg_list->group->qgroupid; *inherit = res; return 0; |