diff options
| author | Li Zefan <lizf@cn.fujitsu.com> | 2011-03-28 04:01:25 +0200 |
|---|---|---|
| committer | Chris Mason <chris.mason@oracle.com> | 2011-04-05 07:20:24 +0200 |
| commit | 08fe4db170b4193603d9d31f40ebaf652d07ac9c (patch) | |
| tree | 2d0d2abe40b77266600653e399d4973a679716a9 /fs/btrfs/transaction.c | |
| parent | btrfs: clear __GFP_FS flag in the space cache inode (diff) | |
| download | linux-08fe4db170b4193603d9d31f40ebaf652d07ac9c.tar.xz linux-08fe4db170b4193603d9d31f40ebaf652d07ac9c.zip | |
Btrfs: Fix uninitialized root flags for subvolumes
root_item->flags and root_item->byte_limit are not initialized when
a subvolume is created. This bug is not revealed until we added
readonly snapshot support - now you mount a btrfs filesystem and you
may find the subvolumes in it are readonly.
To work around this problem, we steal a bit from root_item->inode_item->flags,
and use it to indicate if those fields have been properly initialized.
When we read a tree root from disk, we check if the bit is set, and if
not we'll set the flag and initialize the two fields of the root item.
Reported-by: Andreas Philipp <philipp.andreas@gmail.com>
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Tested-by: Andreas Philipp <philipp.andreas@gmail.com>
cc: stable@kernel.org
Signed-off-by: Chris Mason <chris.mason@oracle.com>
Diffstat (limited to 'fs/btrfs/transaction.c')
| -rw-r--r-- | fs/btrfs/transaction.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index d01cc249a8d3..5b158da7e0bb 100644 --- a/fs/btrfs/transaction.c +++ b/fs/btrfs/transaction.c @@ -976,6 +976,7 @@ static noinline int create_pending_snapshot(struct btrfs_trans_handle *trans, record_root_in_trans(trans, root); btrfs_set_root_last_snapshot(&root->root_item, trans->transid); memcpy(new_root_item, &root->root_item, sizeof(*new_root_item)); + btrfs_check_and_init_root_item(new_root_item); root_flags = btrfs_root_flags(new_root_item); if (pending->readonly) |