diff options
| author | Filipe Manana <fdmanana@suse.com> | 2022-04-06 18:07:54 +0200 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2022-04-19 15:44:17 +0200 |
| commit | 50ff57888d0b13440e7f4cde05dc339ee8d0f1f8 (patch) | |
| tree | 57b09b8333dfe7f61d02ad8509bc5c30f23a4ab9 /fs/btrfs/tree-log.c | |
| parent | btrfs: fix btrfs_submit_compressed_write cgroup attribution (diff) | |
| download | linux-50ff57888d0b13440e7f4cde05dc339ee8d0f1f8.tar.xz linux-50ff57888d0b13440e7f4cde05dc339ee8d0f1f8.zip | |
btrfs: fix leaked plug after failure syncing log on zoned filesystems
On a zoned filesystem, if we fail to allocate the root node for the log
root tree while syncing the log, we end up returning without finishing
the IO plug we started before, resulting in leaking resources as we
have started writeback for extent buffers of a log tree before. That
allocation failure, which typically is either -ENOMEM or -ENOSPC, is not
fatal and the fsync can safely fallback to a full transaction commit.
So release the IO plug if we fail to allocate the extent buffer for the
root of the log root tree when syncing the log on a zoned filesystem.
Fixes: 3ddebf27fcd3a9 ("btrfs: zoned: reorder log node allocation on zoned filesystem")
CC: stable@vger.kernel.org # 5.15+
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/tree-log.c')
| -rw-r--r-- | fs/btrfs/tree-log.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c index 571dae8ad65e..09e4f1a04e6f 100644 --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c @@ -3188,6 +3188,7 @@ int btrfs_sync_log(struct btrfs_trans_handle *trans, ret = btrfs_alloc_log_tree_node(trans, log_root_tree); if (ret) { mutex_unlock(&fs_info->tree_root->log_mutex); + blk_finish_plug(&plug); goto out; } } |