diff options
| author | Filipe Manana <fdmanana@suse.com> | 2023-10-05 13:11:09 +0200 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-10-12 16:44:18 +0200 |
| commit | 3cf63ddf29f94cfedae12a6ebebeaedbfc5d5de1 (patch) | |
| tree | 57ed59ee24c408f06d0cd277ac543c97e654b592 /fs/btrfs/tree-log.c | |
| parent | btrfs: update comment for struct btrfs_inode::lock (diff) | |
| download | linux-3cf63ddf29f94cfedae12a6ebebeaedbfc5d5de1.tar.xz linux-3cf63ddf29f94cfedae12a6ebebeaedbfc5d5de1.zip | |
btrfs: remove pointless empty log context list check when syncing log
When syncing the log, if we get an error when updating the log root, we
check first if the log root tree context is in a log context list, and if
so it deletes from the log root tree context from the list. This check
however is pointless because at this moment the context is always in a
list, he have just added it to a context list. The check became pointless
after commit a93e01682e28 ("btrfs: remove no longer needed use of
log_writers for the log root tree"). So remove this now pointless empty
list check.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/tree-log.c')
| -rw-r--r-- | fs/btrfs/tree-log.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c index 958bb23d3d99..8b3893c01734 100644 --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c @@ -2996,9 +2996,7 @@ int btrfs_sync_log(struct btrfs_trans_handle *trans, */ ret = update_log_root(trans, log, &new_root_item); if (ret) { - if (!list_empty(&root_log_ctx.list)) - list_del_init(&root_log_ctx.list); - + list_del_init(&root_log_ctx.list); blk_finish_plug(&plug); btrfs_set_log_full_commit(trans); if (ret != -ENOSPC) |