diff options
| author | David Sterba <dsterba@suse.com> | 2019-10-01 19:44:42 +0200 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2019-11-18 12:46:50 +0100 |
| commit | c1499166d10ae734b5ec5cc7982bd9b9ee7f9fe6 (patch) | |
| tree | cae2b40f5c2854fbfc478d7399c40102699c6cfb /fs/btrfs/volumes.c | |
| parent | btrfs: add 64bit safe helper for power of two checks (diff) | |
| download | linux-c1499166d10ae734b5ec5cc7982bd9b9ee7f9fe6.tar.xz linux-c1499166d10ae734b5ec5cc7982bd9b9ee7f9fe6.zip | |
btrfs: use has_single_bit_set for clarity
Replace is_power_of_2 with the helper that is self-documenting and
remove the open coded call in alloc_profile_is_valid.
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/volumes.c')
| -rw-r--r-- | fs/btrfs/volumes.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 8d1555be03ad..f7b45e4b7de4 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -3844,12 +3844,7 @@ static int alloc_profile_is_valid(u64 flags, int extended) if (flags == 0) return !extended; /* "0" is valid for usual profiles */ - /* true if exactly one bit set */ - /* - * Don't use is_power_of_2(unsigned long) because it won't work - * for the single profile (1ULL << 48) on 32-bit CPUs. - */ - return flags != 0 && (flags & (flags - 1)) == 0; + return has_single_bit_set(flags); } static inline int balance_need_close(struct btrfs_fs_info *fs_info) |