diff options
| author | Miao Xie <miaox@cn.fujitsu.com> | 2013-03-04 10:45:06 +0100 |
|---|---|---|
| committer | Josef Bacik <jbacik@fusionio.com> | 2013-03-04 22:33:22 +0100 |
| commit | 00d71c9c17b1fd28fa54f323a29a0e23c6d3de40 (patch) | |
| tree | fb0ffcef82cf903fac454a19745df21485c8d5b6 /fs/btrfs | |
| parent | Btrfs: fix wrong handle at error path of create_snapshot() when the commit fails (diff) | |
| download | linux-00d71c9c17b1fd28fa54f323a29a0e23c6d3de40.tar.xz linux-00d71c9c17b1fd28fa54f323a29a0e23c6d3de40.zip | |
Btrfs: fix unclosed transaction handler when the async transaction commitment fails
If the async transaction commitment failed, we need close the
current transaction handler, or the current transaction will be
blocked to commit because of this orphan handler.
We fix the problem by doing sync transaction commitment, that is
to invoke btrfs_commit_transaction().
Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/ioctl.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 94c0e42dfa1e..3fdfabcc1aaa 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -527,6 +527,8 @@ fail: if (async_transid) { *async_transid = trans->transid; err = btrfs_commit_transaction_async(trans, root, 1); + if (err) + err = btrfs_commit_transaction(trans, root); } else { err = btrfs_commit_transaction(trans, root); } @@ -592,6 +594,8 @@ static int create_snapshot(struct btrfs_root *root, struct inode *dir, *async_transid = trans->transid; ret = btrfs_commit_transaction_async(trans, root->fs_info->extent_root, 1); + if (ret) + ret = btrfs_commit_transaction(trans, root); } else { ret = btrfs_commit_transaction(trans, root->fs_info->extent_root); |