diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2018-12-10 09:40:11 +0100 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2018-12-10 09:40:11 +0100 |
commit | a40612ef0ee1e524aafee58d0e5713cf5fdb3d62 (patch) | |
tree | d91ab06356cb2ffa1b49320127ed35a948c33d98 /fs/btrfs | |
parent | Linux 4.20-rc1 (diff) | |
download | linux-a40612ef0ee1e524aafee58d0e5713cf5fdb3d62.tar.xz linux-a40612ef0ee1e524aafee58d0e5713cf5fdb3d62.zip |
genheaders: %-<width>s had been there since v6; %-*s - since v7
Please, use at least K&R C; printf had been able to left-adjust
a field for as long as stdio existed and use of '*' for variable
width had been there since v7. Yes, the first edition of K&R
didn't cover the latter feature (it slightly predates v7), but
you are using a much later feature of the language than that -
in K&R C
static char *stoupperx(const char *s)
{
...
}
would've been spelled as
static char *stoupperx(s)
char *s;
{
...
}
While we are at it, the use of strstr() is bogus - it finds the
_first_ instance of substring, so it's a lousy fit for checking
if a string ends with given suffix...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/btrfs')
0 files changed, 0 insertions, 0 deletions