diff options
| author | Naohiro Aota <naohiro.aota@wdc.com> | 2024-07-11 16:50:58 +0200 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2024-07-29 19:21:04 +0200 |
| commit | d89c285d28491d8f10534c262ac9e6bdcbe1b4d2 (patch) | |
| tree | 65e74d64790fb797fa3507f86e39f7aa691786f6 /fs/btrfs | |
| parent | btrfs: make cow_file_range_inline() honor locked_page on error (diff) | |
| download | linux-d89c285d28491d8f10534c262ac9e6bdcbe1b4d2.tar.xz linux-d89c285d28491d8f10534c262ac9e6bdcbe1b4d2.zip | |
btrfs: do not subtract delalloc from avail bytes
The block group's avail bytes printed when dumping a space info subtract
the delalloc_bytes. However, as shown in btrfs_add_reserved_bytes() and
btrfs_free_reserved_bytes(), it is added or subtracted along with
"reserved" for the delalloc case, which means the "delalloc_bytes" is a
part of the "reserved" bytes. So, excluding it to calculate the avail space
counts delalloc_bytes twice, which can lead to an invalid result.
Fixes: e50b122b832b ("btrfs: print available space for a block group when dumping a space info")
CC: stable@vger.kernel.org # 6.6+
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: Boris Burkov <boris@bur.io>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/space-info.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c index 9ac94d3119e8..c1d9d3664400 100644 --- a/fs/btrfs/space-info.c +++ b/fs/btrfs/space-info.c @@ -583,8 +583,7 @@ again: spin_lock(&cache->lock); avail = cache->length - cache->used - cache->pinned - - cache->reserved - cache->delalloc_bytes - - cache->bytes_super - cache->zone_unusable; + cache->reserved - cache->bytes_super - cache->zone_unusable; btrfs_info(fs_info, "block group %llu has %llu bytes, %llu used %llu pinned %llu reserved %llu delalloc %llu super %llu zone_unusable (%llu bytes available) %s", cache->start, cache->length, cache->used, cache->pinned, |