diff options
| author | Jens Axboe <axboe@fb.com> | 2015-07-24 20:37:59 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2015-07-29 16:55:20 +0200 |
| commit | b7c44ed9d2fc6b461378c65eaf144ccc80a47772 (patch) | |
| tree | 2f38bdc1cf7ea6c924f6e1d52cf5913c370e08b6 /fs/buffer.c | |
| parent | block: add a bi_error field to struct bio (diff) | |
| download | linux-b7c44ed9d2fc6b461378c65eaf144ccc80a47772.tar.xz linux-b7c44ed9d2fc6b461378c65eaf144ccc80a47772.zip | |
block: manipulate bio->bi_flags through helpers
Some places use helpers now, others don't. We only have the 'is set'
helper, add helpers for setting and clearing flags too.
It was a bit of a mess of atomic vs non-atomic access. With
BIO_UPTODATE gone, we don't have any risk of concurrent access to the
flags. So relax the restriction and don't make any of them atomic. The
flags that do have serialization issues (reffed and chained), we
already handle those separately.
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'fs/buffer.c')
| -rw-r--r-- | fs/buffer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/buffer.c b/fs/buffer.c index 7a49bb84ecb5..7887bb466368 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -2961,7 +2961,7 @@ static void end_bio_bh_io_sync(struct bio *bio) { struct buffer_head *bh = bio->bi_private; - if (unlikely (test_bit(BIO_QUIET,&bio->bi_flags))) + if (unlikely(bio_flagged(bio, BIO_QUIET))) set_bit(BH_Quiet, &bh->b_state); bh->b_end_io(bh, !bio->bi_error); |