diff options
| author | Yan, Zheng <zyan@redhat.com> | 2015-03-24 04:36:08 +0100 |
|---|---|---|
| committer | Ilya Dryomov <idryomov@gmail.com> | 2015-04-20 17:55:36 +0200 |
| commit | 571ade336ac89f5db602f7df992152e4f4b945bc (patch) | |
| tree | f10c4a63d4f5c624c9a6ddcc4a0ca941583e3d30 /fs/ceph | |
| parent | ceph: keep i_snap_realm while there are writers (diff) | |
| download | linux-571ade336ac89f5db602f7df992152e4f4b945bc.tar.xz linux-571ade336ac89f5db602f7df992152e4f4b945bc.zip | |
ceph: don't mark dirty caps when there is no auth cap
No i_auth_cap means reconnecting to MDS was denied. So don't
add new dirty caps.
Signed-off-by: Yan, Zheng <zyan@redhat.com>
Diffstat (limited to 'fs/ceph')
| -rw-r--r-- | fs/ceph/caps.c | 8 | ||||
| -rw-r--r-- | fs/ceph/mds_client.c | 2 |
2 files changed, 8 insertions, 2 deletions
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c index 4ddadc13d162..37a42353b983 100644 --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -1404,6 +1404,13 @@ int __ceph_mark_dirty_caps(struct ceph_inode_info *ci, int mask) int was = ci->i_dirty_caps; int dirty = 0; + if (!ci->i_auth_cap) { + pr_warn("__mark_dirty_caps %p %llx mask %s, " + "but no auth cap (session was closed?)\n", + inode, ceph_ino(inode), ceph_cap_string(mask)); + return 0; + } + dout("__mark_dirty_caps %p %s dirty %s -> %s\n", &ci->vfs_inode, ceph_cap_string(mask), ceph_cap_string(was), ceph_cap_string(was | mask)); @@ -1414,7 +1421,6 @@ int __ceph_mark_dirty_caps(struct ceph_inode_info *ci, int mask) ci->i_snap_realm->cached_context); dout(" inode %p now dirty snapc %p auth cap %p\n", &ci->vfs_inode, ci->i_head_snapc, ci->i_auth_cap); - WARN_ON(!ci->i_auth_cap); BUG_ON(!list_empty(&ci->i_dirty_item)); spin_lock(&mdsc->cap_dirty_lock); list_add(&ci->i_dirty_item, &mdsc->cap_dirty); diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c index 0122491d947c..0cfc2d163549 100644 --- a/fs/ceph/mds_client.c +++ b/fs/ceph/mds_client.c @@ -1098,7 +1098,7 @@ static int remove_session_caps_cb(struct inode *inode, struct ceph_cap *cap, cap, ci, &ci->vfs_inode); spin_lock(&ci->i_ceph_lock); __ceph_remove_cap(cap, false); - if (!__ceph_is_any_real_caps(ci)) { + if (!ci->i_auth_cap) { struct ceph_mds_client *mdsc = ceph_sb_to_client(inode->i_sb)->mdsc; |