diff options
| author | Sage Weil <sage@newdream.net> | 2010-11-09 21:24:53 +0100 |
|---|---|---|
| committer | Sage Weil <sage@newdream.net> | 2010-11-09 21:24:53 +0100 |
| commit | e98b6fed84d0f0155d7b398e0dfeac74c792f2d0 (patch) | |
| tree | 0762cba398c39329dc5f056ddfccebf6768d2555 /fs/ceph | |
| parent | ceph: fix update of ctime from MDS (diff) | |
| download | linux-e98b6fed84d0f0155d7b398e0dfeac74c792f2d0.tar.xz linux-e98b6fed84d0f0155d7b398e0dfeac74c792f2d0.zip | |
ceph: fix comment, remove extraneous args
The offset/length arguments aren't used.
Signed-off-by: Sage Weil <sage@newdream.net>
Diffstat (limited to 'fs/ceph')
| -rw-r--r-- | fs/ceph/file.c | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 87ee944724f8..603fd00af0a6 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -376,21 +376,19 @@ static ssize_t ceph_sync_read(struct file *file, char __user *data, dout("sync_read on file %p %llu~%u %s\n", file, off, len, (file->f_flags & O_DIRECT) ? "O_DIRECT" : ""); - if (file->f_flags & O_DIRECT) { - pages = ceph_get_direct_page_vector(data, num_pages, off, len); - - /* - * flush any page cache pages in this range. this - * will make concurrent normal and O_DIRECT io slow, - * but it will at least behave sensibly when they are - * in sequence. - */ - } else { + if (file->f_flags & O_DIRECT) + pages = ceph_get_direct_page_vector(data, num_pages); + else pages = ceph_alloc_page_vector(num_pages, GFP_NOFS); - } if (IS_ERR(pages)) return PTR_ERR(pages); + /* + * flush any page cache pages in this range. this + * will make concurrent normal and sync io slow, + * but it will at least behave sensibly when they are + * in sequence. + */ ret = filemap_write_and_wait(inode->i_mapping); if (ret < 0) goto done; |