diff options
| author | Steve French <stfrench@microsoft.com> | 2021-07-22 20:50:41 +0200 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2021-07-22 20:50:41 +0200 |
| commit | 21a64910997e0c1d268bebf9b1217ba5804d592d (patch) | |
| tree | 38f37375d0329f1f3ff74931dd0d8a0e39e3cf34 /fs/cifs/cifssmb.c | |
| parent | cifs: support share failover when remounting (diff) | |
| download | linux-21a64910997e0c1d268bebf9b1217ba5804d592d.tar.xz linux-21a64910997e0c1d268bebf9b1217ba5804d592d.zip | |
CIFS: Clarify SMB1 code for POSIX Create
Coverity also complains about the way we calculate the offset
(starting from the address of a 4 byte array within the
header structure rather than from the beginning of the struct
plus 4 bytes) for SMB1 CIFSPOSIXCreate. This changeset
doesn't change the address but makes it slightly clearer.
Addresses-Coverity: 711518 ("Out of bounds write")
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to '')
| -rw-r--r-- | fs/cifs/cifssmb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index f72e3b3dca69..d4144c182604 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -1081,7 +1081,8 @@ PsxCreat: param_offset = offsetof(struct smb_com_transaction2_spi_req, InformationLevel) - 4; offset = param_offset + params; - pdata = (OPEN_PSX_REQ *)(((char *)&pSMB->hdr.Protocol) + offset); + /* SMB offsets are from the beginning of SMB which is 4 bytes in, after RFC1001 field */ + pdata = (OPEN_PSX_REQ *)((char *)(pSMB) + offset + 4); pdata->Level = cpu_to_le16(SMB_QUERY_FILE_UNIX_BASIC); pdata->Permissions = cpu_to_le64(mode); pdata->PosixOpenFlags = cpu_to_le32(posix_flags); |