diff options
| author | Michael Opdenacker <michael.opdenacker@free-electrons.com> | 2014-04-15 10:06:50 +0200 |
|---|---|---|
| committer | Steve French <smfrench@gmail.com> | 2014-04-17 06:08:57 +0200 |
| commit | 1f80c0cc39e587edd06a36b43ba3a3b09d4ac428 (patch) | |
| tree | 68539f36bda4fae674846affe1f8464197f7371a /fs/cifs/file.c | |
| parent | cifs: fix error handling cifs_user_readv (diff) | |
| download | linux-1f80c0cc39e587edd06a36b43ba3a3b09d4ac428.tar.xz linux-1f80c0cc39e587edd06a36b43ba3a3b09d4ac428.zip | |
cif: fix dead code
This issue was found by Coverity (CID 1202536)
This proposes a fix for a statement that creates dead code.
The "rc < 0" statement is within code that is run
with "rc > 0".
It seems like "err < 0" was meant to be used here.
This way, the error code is returned by the function.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Steve French <smfrench@gmail.com>
Diffstat (limited to '')
| -rw-r--r-- | fs/cifs/file.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index a875eedfd928..5ed03e0b8b40 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -2599,7 +2599,7 @@ cifs_writev(struct kiocb *iocb, const struct iovec *iov, ssize_t err; err = generic_write_sync(file, iocb->ki_pos - rc, rc); - if (rc < 0) + if (err < 0) rc = err; } } else { |