diff options
| author | Steve French <stfrench@microsoft.com> | 2018-11-15 07:33:05 +0100 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2018-12-24 05:38:14 +0100 |
| commit | 97aa495a89a631822431b789b8553b81e3460255 (patch) | |
| tree | ebeb0a24494ff55517a016ffc47a7d790d82f84e /fs/cifs/inode.c | |
| parent | cifs: smb2 commands can not be negative, remove confusing check (diff) | |
| download | linux-97aa495a89a631822431b789b8553b81e3460255.tar.xz linux-97aa495a89a631822431b789b8553b81e3460255.zip | |
cifs: address trivial coverity warning
This is not actually a bug but as Coverity points out we shouldn't
be doing an "|=" on a value which hasn't been set (although technically
it was memset to zero so isn't a bug) and so might as well change
"|=" to "=" in this line
Detected by CoverityScan, CID#728535 ("Unitialized scalar variable")
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Diffstat (limited to 'fs/cifs/inode.c')
| -rw-r--r-- | fs/cifs/inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index a81a9df997c1..1fe9f3b01703 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -333,7 +333,7 @@ cifs_create_dfs_fattr(struct cifs_fattr *fattr, struct super_block *sb) fattr->cf_mtime = timespec64_trunc(fattr->cf_mtime, sb->s_time_gran); fattr->cf_atime = fattr->cf_ctime = fattr->cf_mtime; fattr->cf_nlink = 2; - fattr->cf_flags |= CIFS_FATTR_DFS_REFERRAL; + fattr->cf_flags = CIFS_FATTR_DFS_REFERRAL; } static int |