diff options
| author | Steve French <stfrench@microsoft.com> | 2018-10-19 07:45:21 +0200 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2018-10-24 04:16:05 +0200 |
| commit | 1e77a8c204c9d1b655c61751b8ad0fde22421dbb (patch) | |
| tree | 9f652ecaa32824ae5938c84d02545d1edf07a003 /fs/cifs/inode.c | |
| parent | smb3: send backup intent on compounded query info (diff) | |
| download | linux-1e77a8c204c9d1b655c61751b8ad0fde22421dbb.tar.xz linux-1e77a8c204c9d1b655c61751b8ad0fde22421dbb.zip | |
smb3: do not attempt cifs operation in smb3 query info error path
If backupuid mount option is sent, we can incorrectly retry
(on access denied on query info) with a cifs (FindFirst) operation
on an smb3 mount which causes the server to force the session close.
We set backup intent on open so no need for this fallback.
See kernel bugzilla 201435
Signed-off-by: Steve French <stfrench@microsoft.com>
CC: Stable <stable@vger.kernel.org>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Diffstat (limited to 'fs/cifs/inode.c')
| -rw-r--r-- | fs/cifs/inode.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index 0945d40030eb..7483c09317b9 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -781,7 +781,15 @@ cifs_get_inode_info(struct inode **inode, const char *full_path, } else if (rc == -EREMOTE) { cifs_create_dfs_fattr(&fattr, sb); rc = 0; - } else if (rc == -EACCES && backup_cred(cifs_sb)) { + } else if ((rc == -EACCES) && backup_cred(cifs_sb) && + (strcmp(server->vals->version_string, SMB1_VERSION_STRING) + == 0)) { + /* + * For SMB2 and later the backup intent flag is already + * sent if needed on open and there is no path based + * FindFirst operation to use to retry with + */ + srchinf = kzalloc(sizeof(struct cifs_search_info), GFP_KERNEL); if (srchinf == NULL) { |