diff options
| author | Steve French <stfrench@microsoft.com> | 2021-06-19 22:53:18 +0200 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2021-06-21 04:28:17 +0200 |
| commit | e39df24169a2ceb0d359eb3a05ff982711f2eb32 (patch) | |
| tree | 67518454f68b186c2990e9f152328f5ad4ddbedb /fs/cifs/inode.c | |
| parent | smb3: fix uninitialized value for port in witness protocol move (diff) | |
| download | linux-e39df24169a2ceb0d359eb3a05ff982711f2eb32.tar.xz linux-e39df24169a2ceb0d359eb3a05ff982711f2eb32.zip | |
cifs: fix SMB1 error path in cifs_get_file_info_unix
We were trying to fill in uninitialized file attributes in the error case.
Addresses-Coverity: 139689 ("Uninitialized variables")
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs/inode.c')
| -rw-r--r-- | fs/cifs/inode.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index 046b51dd34df..b96b253e7635 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -355,9 +355,12 @@ cifs_get_file_info_unix(struct file *filp) } else if (rc == -EREMOTE) { cifs_create_dfs_fattr(&fattr, inode->i_sb); rc = 0; - } + } else + goto cifs_gfiunix_out; rc = cifs_fattr_to_inode(inode, &fattr); + +cifs_gfiunix_out: free_xid(xid); return rc; } |