diff options
author | Jeff Layton <jlayton@redhat.com> | 2010-09-03 18:00:49 +0200 |
---|---|---|
committer | Steve French <sfrench@us.ibm.com> | 2010-09-08 23:22:30 +0200 |
commit | 522bbe65a2415fabce618186fc7777eb4c502989 (patch) | |
tree | 6eb66dac2892728d93e3220511c0ec7e35f40ce4 /fs/cifs/netmisc.c | |
parent | [CIFS] ntlmv2/ntlmssp remove-unused-function CalcNTLMv2_partial_mac_key (diff) | |
download | linux-522bbe65a2415fabce618186fc7777eb4c502989.tar.xz linux-522bbe65a2415fabce618186fc7777eb4c502989.zip |
cifs: prevent cifsd from exiting prematurely
When cifs_demultiplex_thread exits, it does a number of cleanup tasks
including freeing the TCP_Server_Info struct. Much of the existing code
in cifs assumes that when there is a cisfSesInfo struct, that it holds a
reference to a valid TCP_Server_Info struct.
We can never allow cifsd to exit when a cifsSesInfo struct is still
holding a reference to the server. The server pointers will then point
to freed memory.
This patch eliminates a couple of questionable conditions where it does
this. The idea here is to make an -EINTR return from kernel_recvmsg
behave the same way as -ERESTARTSYS or -EAGAIN. If the task was
signalled from cifs_put_tcp_session, then tcpStatus will be CifsExiting,
and the kernel_recvmsg call will return quickly.
There's also another condition where this can occur too -- if the
tcpStatus is still in CifsNew, then it will also exit if the server
closes the socket prematurely. I think we'll probably also need to fix
that situation, but that requires a bit more consideration.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/netmisc.c')
0 files changed, 0 insertions, 0 deletions