diff options
| author | Enzo Matsumiya <ematsumiya@suse.de> | 2022-08-17 21:08:34 +0200 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2022-08-18 06:30:49 +0200 |
| commit | 400d0ad63b190895e29f43bc75b1260111d3fd34 (patch) | |
| tree | eea19d02d6d80a3bb557d31c4253feac456c81f6 /fs/cifs/smb2file.c | |
| parent | cifs: remove unused server parameter from calc_smb_size() (diff) | |
| download | linux-400d0ad63b190895e29f43bc75b1260111d3fd34.tar.xz linux-400d0ad63b190895e29f43bc75b1260111d3fd34.zip | |
cifs: remove useless parameter 'is_fsctl' from SMB2_ioctl()
SMB2_ioctl() is always called with is_fsctl = true, so doesn't make any
sense to have it at all.
Thus, always set SMB2_0_IOCTL_IS_FSCTL flag on the request.
Also, as per MS-SMB2 3.3.5.15 "Receiving an SMB2 IOCTL Request", servers
must fail the request if the request flags is zero anyway.
Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
Reviewed-by: Tom Talpey <tom@talpey.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs/smb2file.c')
| -rw-r--r-- | fs/cifs/smb2file.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/cifs/smb2file.c b/fs/cifs/smb2file.c index f5dcc4940b6d..9dfd2dd612c2 100644 --- a/fs/cifs/smb2file.c +++ b/fs/cifs/smb2file.c @@ -61,7 +61,6 @@ smb2_open_file(const unsigned int xid, struct cifs_open_parms *oparms, nr_ioctl_req.Reserved = 0; rc = SMB2_ioctl(xid, oparms->tcon, fid->persistent_fid, fid->volatile_fid, FSCTL_LMR_REQUEST_RESILIENCY, - true /* is_fsctl */, (char *)&nr_ioctl_req, sizeof(nr_ioctl_req), CIFSMaxBufSize, NULL, NULL /* no return info */); if (rc == -EOPNOTSUPP) { |