diff options
| author | Ronnie Sahlberg <lsahlber@redhat.com> | 2020-01-30 20:52:51 +0100 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2020-01-30 22:23:55 +0100 |
| commit | c54849ddd832ae0a45cab16bcd1ed2db7da090d7 (patch) | |
| tree | 46f1325d71b915411cbd9bf17628be5f77f0164a /fs/cifs/smb2pdu.c | |
| parent | Merge tag '5.6-smb3-fixes-and-dfs-and-readdir-improvements' of git://git.samb... (diff) | |
| download | linux-c54849ddd832ae0a45cab16bcd1ed2db7da090d7.tar.xz linux-c54849ddd832ae0a45cab16bcd1ed2db7da090d7.zip | |
cifs: fix soft mounts hanging in the reconnect code
RHBZ: 1795429
In recent DFS updates we have a new variable controlling how many times we will
retry to reconnect the share.
If DFS is not used, then this variable is initialized to 0 in:
static inline int
dfs_cache_get_nr_tgts(const struct dfs_cache_tgt_list *tl)
{
return tl ? tl->tl_numtgts : 0;
}
This means that in the reconnect loop in smb2_reconnect() we will immediately wrap retries to -1
and never actually get to pass this conditional:
if (--retries)
continue;
The effect is that we no longer reach the point where we fail the commands with -EHOSTDOWN
and basically the kernel threads are virtually hung and unkillable.
Fixes: a3a53b7603798fd8 (cifs: Add support for failover in smb2_reconnect())
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
CC: Stable <stable@vger.kernel.org>
Diffstat (limited to 'fs/cifs/smb2pdu.c')
| -rw-r--r-- | fs/cifs/smb2pdu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index 7edba3e6d5e6..14f209f7376f 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -312,7 +312,7 @@ smb2_reconnect(__le16 smb2_command, struct cifs_tcon *tcon) if (server->tcpStatus != CifsNeedReconnect) break; - if (--retries) + if (retries && --retries) continue; /* |