diff options
| author | Colin Ian King <colin.king@canonical.com> | 2019-05-17 10:12:33 +0200 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2019-05-29 02:11:35 +0200 |
| commit | 210782038b54ec8e9059a3c12d6f6ae173efa3a9 (patch) | |
| tree | beebedc72c2076496d78a7c80092f6bcd39db28b /fs/cifs/smb2pdu.c | |
| parent | Linux 5.2-rc2 (diff) | |
| download | linux-210782038b54ec8e9059a3c12d6f6ae173efa3a9.tar.xz linux-210782038b54ec8e9059a3c12d6f6ae173efa3a9.zip | |
cifs: fix memory leak of pneg_inbuf on -EOPNOTSUPP ioctl case
Currently in the case where SMB2_ioctl returns the -EOPNOTSUPP error
there is a memory leak of pneg_inbuf. Fix this by returning via
the out_free_inbuf exit path that will perform the relevant kfree.
Addresses-Coverity: ("Resource leak")
Fixes: 969ae8e8d4ee ("cifs: Accept validate negotiate if server return NT_STATUS_NOT_SUPPORTED")
CC: Stable <stable@vger.kernel.org> # v5.1+
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs/smb2pdu.c')
| -rw-r--r-- | fs/cifs/smb2pdu.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index 710ceb875161..5b8d1482ffbd 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -1054,7 +1054,8 @@ int smb3_validate_negotiate(const unsigned int xid, struct cifs_tcon *tcon) * not supported error. Client should accept it. */ cifs_dbg(VFS, "Server does not support validate negotiate\n"); - return 0; + rc = 0; + goto out_free_inbuf; } else if (rc != 0) { cifs_dbg(VFS, "validate protocol negotiate failed: %d\n", rc); rc = -EIO; |