diff options
| author | Ronnie Sahlberg <lsahlber@redhat.com> | 2020-11-30 02:29:20 +0100 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2020-12-04 00:12:14 +0100 |
| commit | ea64370bcae126a88cd26a16f1abcc23ab2b9a55 (patch) | |
| tree | 45513cee94669dca19d662a2c35aa410ef9924ac /fs/cifs/smb2pdu.h | |
| parent | cifs: add NULL check for ses->tcon_ipc (diff) | |
| download | linux-ea64370bcae126a88cd26a16f1abcc23ab2b9a55.tar.xz linux-ea64370bcae126a88cd26a16f1abcc23ab2b9a55.zip | |
cifs: refactor create_sd_buf() and and avoid corrupting the buffer
When mounting with "idsfromsid" mount option, Azure
corrupted the owner SIDs due to excessive padding
caused by placing the owner fields at the end of the
security descriptor on create. Placing owners at the
front of the security descriptor (rather than the end)
is also safer, as the number of ACEs (that follow it)
are variable.
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Suggested-by: Rohith Surabattula <rohiths@microsoft.com>
CC: Stable <stable@vger.kernel.org> # v5.8
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to '')
| -rw-r--r-- | fs/cifs/smb2pdu.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/cifs/smb2pdu.h b/fs/cifs/smb2pdu.h index f05f9b12f689..fa57b03ca98c 100644 --- a/fs/cifs/smb2pdu.h +++ b/fs/cifs/smb2pdu.h @@ -963,8 +963,6 @@ struct crt_sd_ctxt { struct create_context ccontext; __u8 Name[8]; struct smb3_sd sd; - struct smb3_acl acl; - /* Followed by at least 4 ACEs */ } __packed; |