diff options
| author | Sachin Prabhu <sprabhu@redhat.com> | 2017-03-04 00:41:38 +0100 |
|---|---|---|
| committer | Steve French <smfrench@gmail.com> | 2017-04-07 15:04:40 +0200 |
| commit | 38bd49064a1ecb67baad33598e3d824448ab11ec (patch) | |
| tree | dd922c0d30ddffd7e0bda9e53ddca5165c1afb84 /fs/cifs/transport.c | |
| parent | Merge tag 'xfs-4.11-fixes-3' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux (diff) | |
| download | linux-38bd49064a1ecb67baad33598e3d824448ab11ec.tar.xz linux-38bd49064a1ecb67baad33598e3d824448ab11ec.zip | |
Handle mismatched open calls
A signal can interrupt a SendReceive call which result in incoming
responses to the call being ignored. This is a problem for calls such as
open which results in the successful response being ignored. This
results in an open file resource on the server.
The patch looks into responses which were cancelled after being sent and
in case of successful open closes the open fids.
For this patch, the check is only done in SendReceive2()
RH-bz: 1403319
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Cc: Stable <stable@vger.kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | fs/cifs/transport.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index 526f0533cb4e..f6e13a977fc8 100644 --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c @@ -752,9 +752,11 @@ cifs_send_recv(const unsigned int xid, struct cifs_ses *ses, rc = wait_for_response(ses->server, midQ); if (rc != 0) { + cifs_dbg(FYI, "Cancelling wait for mid %llu\n", midQ->mid); send_cancel(ses->server, rqst, midQ); spin_lock(&GlobalMid_Lock); if (midQ->mid_state == MID_REQUEST_SUBMITTED) { + midQ->mid_flags |= MID_WAIT_CANCELLED; midQ->callback = DeleteMidQEntry; spin_unlock(&GlobalMid_Lock); add_credits(ses->server, 1, optype); |