diff options
| author | Steve French <stfrench@microsoft.com> | 2018-11-14 08:37:39 +0100 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2018-12-24 05:37:23 +0100 |
| commit | f5942db5ef25531d53f2aa2ff84a46e1763b4196 (patch) | |
| tree | 15c514b78ef261f9595d0bf52dcdd0dc225026aa /fs/cifs/transport.c | |
| parent | cifs: use a compound for setting an xattr (diff) | |
| download | linux-f5942db5ef25531d53f2aa2ff84a46e1763b4196.tar.xz linux-f5942db5ef25531d53f2aa2ff84a46e1763b4196.zip | |
cifs: smb2 commands can not be negative, remove confusing check
As Coverity points out le16_to_cpu(midEntry->Command) can not be
less than zero.
Detected by CoverityScan, CID#1438650 ("Macro compares unsigned to 0")
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Diffstat (limited to 'fs/cifs/transport.c')
| -rw-r--r-- | fs/cifs/transport.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index 83ff0c25710d..5be7302853b6 100644 --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c @@ -126,9 +126,11 @@ DeleteMidQEntry(struct mid_q_entry *midEntry) if ((slow_rsp_threshold != 0) && time_after(now, midEntry->when_alloc + (slow_rsp_threshold * HZ)) && (midEntry->command != command)) { - /* smb2slowcmd[NUMBER_OF_SMB2_COMMANDS] counts by command */ - if ((le16_to_cpu(midEntry->command) < NUMBER_OF_SMB2_COMMANDS) && - (le16_to_cpu(midEntry->command) >= 0)) + /* + * smb2slowcmd[NUMBER_OF_SMB2_COMMANDS] counts by command + * NB: le16_to_cpu returns unsigned so can not be negative below + */ + if (le16_to_cpu(midEntry->command) < NUMBER_OF_SMB2_COMMANDS) cifs_stats_inc(&midEntry->server->smb2slowcmd[le16_to_cpu(midEntry->command)]); trace_smb3_slow_rsp(le16_to_cpu(midEntry->command), |