summaryrefslogtreecommitdiffstats
path: root/fs/cifs
diff options
context:
space:
mode:
authorSteve French <smfrench@gmail.com>2015-03-27 07:00:06 +0100
committerSteve French <smfrench@gmail.com>2015-04-01 07:01:47 +0200
commitdfebe40076f3b4966e818eaf94021a7ff788df04 (patch)
treef64db291e6ae72ff31684d03cfacf731d6224a73 /fs/cifs
parentCIFS: session servername can't be null (diff)
downloadlinux-dfebe40076f3b4966e818eaf94021a7ff788df04.tar.xz
linux-dfebe40076f3b4966e818eaf94021a7ff788df04.zip
Fix another dereference before null check warning
null tcon is not possible in these paths so remove confusing null check Reported by Coverity (CID 728519) Signed-off-by: Steve French <smfrench@gmail.com> Reviewed-by: Jeff Layton <jlayton@samba.org>
Diffstat (limited to 'fs/cifs')
-rw-r--r--fs/cifs/smb2pdu.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 78b329f07b3b..65cd7a84c8bc 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -1632,7 +1632,7 @@ SMB2_flush(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid,
rc = SendReceive2(xid, ses, iov, 1, &resp_buftype, 0);
- if ((rc != 0) && tcon)
+ if (rc != 0)
cifs_stats_fail_inc(tcon, SMB2_FLUSH_HE);
free_rsp_buf(resp_buftype, iov[0].iov_base);