diff options
| author | Steve French <smfrench@gmail.com> | 2017-10-25 22:58:31 +0200 |
|---|---|---|
| committer | Steve French <smfrench@gmail.com> | 2017-10-26 19:20:59 +0200 |
| commit | 4587eee04e2ac7ac3ac9fa2bc164fb6e548f99cd (patch) | |
| tree | a852e0565e761bfec1613e71b8846d5e10e10f64 /fs/cifs | |
| parent | SMB: fix validate negotiate info uninitialised memory use (diff) | |
| download | linux-4587eee04e2ac7ac3ac9fa2bc164fb6e548f99cd.tar.xz linux-4587eee04e2ac7ac3ac9fa2bc164fb6e548f99cd.zip | |
SMB3: Validate negotiate request must always be signed
According to MS-SMB2 3.2.55 validate_negotiate request must
always be signed. Some Windows can fail the request if you send it unsigned
See kernel bugzilla bug 197311
CC: Stable <stable@vger.kernel.org>
Acked-by: Ronnie Sahlberg <lsahlber.redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
Diffstat (limited to 'fs/cifs')
| -rw-r--r-- | fs/cifs/smb2pdu.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index ba58af747b43..5331631386a2 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -1979,6 +1979,9 @@ SMB2_ioctl(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, } else iov[0].iov_len = get_rfc1002_length(req) + 4; + /* validate negotiate request must be signed - see MS-SMB2 3.2.5.5 */ + if (opcode == FSCTL_VALIDATE_NEGOTIATE_INFO) + req->hdr.sync_hdr.Flags |= SMB2_FLAGS_SIGNED; rc = SendReceive2(xid, ses, iov, n_iov, &resp_buftype, flags, &rsp_iov); cifs_small_buf_release(req); |