diff options
| author | Steve French <stfrench@microsoft.com> | 2022-05-24 03:54:04 +0200 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2022-05-24 04:02:45 +0200 |
| commit | 9ccfc23a72b669678e4c9ccba98d3d91db1c04cf (patch) | |
| tree | fe73fbd69d1a713717812d2a7bbe8f91e09e26eb /fs/cifs | |
| parent | smb3: check for null tcon (diff) | |
| download | linux-9ccfc23a72b669678e4c9ccba98d3d91db1c04cf.tar.xz linux-9ccfc23a72b669678e4c9ccba98d3d91db1c04cf.zip | |
smb3: don't set rc when used and unneeded in query_info_compound
rc is not checked so should not be set coming back from open_cached_dir
(the cfid pointer is checked instead to see if open_cached_dir failed)
Addresses-Coverity: 1518021 ("Code maintainability issues (UNUSED_VALUE)")
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs')
| -rw-r--r-- | fs/cifs/smb2ops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index 0d7feb9e609e..ed2f8a69658d 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -2700,7 +2700,7 @@ smb2_query_info_compound(const unsigned int xid, struct cifs_tcon *tcon, memset(rsp_iov, 0, sizeof(rsp_iov)); if (!strcmp(path, "")) - rc = open_cached_dir(xid, tcon, path, cifs_sb, &cfid); + open_cached_dir(xid, tcon, path, cifs_sb, &cfid); /* cfid null if open dir failed */ memset(&open_iov, 0, sizeof(open_iov)); rqst[0].rq_iov = open_iov; |