diff options
| author | Xiyu Yang <xiyuyang19@fudan.edu.cn> | 2020-04-25 14:52:26 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2020-04-27 08:17:10 +0200 |
| commit | 8aebfffacfa379ba400da573a5bf9e49634e38cb (patch) | |
| tree | 81791bfd6bc7b1cb22edd31de2e6ea7ea2234506 /fs/configfs | |
| parent | Linux 5.7-rc3 (diff) | |
| download | linux-8aebfffacfa379ba400da573a5bf9e49634e38cb.tar.xz linux-8aebfffacfa379ba400da573a5bf9e49634e38cb.zip | |
configfs: fix config_item refcnt leak in configfs_rmdir()
configfs_rmdir() invokes configfs_get_config_item(), which returns a
reference of the specified config_item object to "parent_item" with
increased refcnt.
When configfs_rmdir() returns, local variable "parent_item" becomes
invalid, so the refcount should be decreased to keep refcount balanced.
The reference counting issue happens in one exception handling path of
configfs_rmdir(). When down_write_killable() fails, the function forgets
to decrease the refcnt increased by configfs_get_config_item(), causing
a refcnt leak.
Fix this issue by calling config_item_put() when down_write_killable()
fails.
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/configfs')
| -rw-r--r-- | fs/configfs/dir.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index cf7b7e1d5bd7..cb733652ecca 100644 --- a/fs/configfs/dir.c +++ b/fs/configfs/dir.c @@ -1519,6 +1519,7 @@ static int configfs_rmdir(struct inode *dir, struct dentry *dentry) spin_lock(&configfs_dirent_lock); configfs_detach_rollback(dentry); spin_unlock(&configfs_dirent_lock); + config_item_put(parent_item); return -EINTR; } frag->frag_dead = true; |