diff options
author | Waiman Long <longman@redhat.com> | 2022-11-05 01:59:02 +0100 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2022-11-17 00:58:44 +0100 |
commit | dae590a6c96c799434e0ff8156ef29b88c257e60 (patch) | |
tree | 47cc80856cb5e7b653e9ba8a70899b04c83ed850 /fs/crypto | |
parent | blk-cgroup: Optimize blkcg_rstat_flush() (diff) | |
download | linux-dae590a6c96c799434e0ff8156ef29b88c257e60.tar.xz linux-dae590a6c96c799434e0ff8156ef29b88c257e60.zip |
blk-cgroup: Flush stats at blkgs destruction path
As noted by Michal, the blkg_iostat_set's in the lockless list
hold reference to blkg's to protect against their removal. Those
blkg's hold reference to blkcg. When a cgroup is being destroyed,
cgroup_rstat_flush() is only called at css_release_work_fn() which is
called when the blkcg reference count reaches 0. This circular dependency
will prevent blkcg from being freed until some other events cause
cgroup_rstat_flush() to be called to flush out the pending blkcg stats.
To prevent this delayed blkcg removal, add a new cgroup_rstat_css_flush()
function to flush stats for a given css and cpu and call it at the blkgs
destruction path, blkcg_destroy_blkgs(), whenever there are still some
pending stats to be flushed. This will ensure that blkcg reference
count can reach 0 ASAP.
Signed-off-by: Waiman Long <longman@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20221105005902.407297-4-longman@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/crypto')
0 files changed, 0 insertions, 0 deletions