diff options
| author | David Teigland <teigland@redhat.com> | 2009-04-08 22:38:43 +0200 |
|---|---|---|
| committer | David Teigland <teigland@redhat.com> | 2009-05-07 17:14:42 +0200 |
| commit | 8511a2728ab82cab398e39d019f5cf1246021c1c (patch) | |
| tree | c1a99f292e9e56fe05d174be771f00a78c66a9b7 /fs/dlm/lockspace.c | |
| parent | dlm: Make name input parameter of {,dlm_}new_lockspace() const (diff) | |
| download | linux-8511a2728ab82cab398e39d019f5cf1246021c1c.tar.xz linux-8511a2728ab82cab398e39d019f5cf1246021c1c.zip | |
dlm: fix use count with multiple joins
When a lockspace was joined multiple times, the global dlm
use count was incremented when it should not have been. This
caused the global dlm threads to not be stopped when all
lockspaces were eventually be removed.
Signed-off-by: David Teigland <teigland@redhat.com>
Diffstat (limited to 'fs/dlm/lockspace.c')
| -rw-r--r-- | fs/dlm/lockspace.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c index 82528d9b72ed..d489fcc86713 100644 --- a/fs/dlm/lockspace.c +++ b/fs/dlm/lockspace.c @@ -419,16 +419,14 @@ static int new_lockspace(const char *name, int namelen, void **lockspace, break; } ls->ls_create_count++; - module_put(THIS_MODULE); - error = 1; /* not an error, return 0 */ + *lockspace = ls; + error = 1; break; } spin_unlock(&lslist_lock); - if (error < 0) - goto out; if (error) - goto ret_zero; + goto out; error = -ENOMEM; @@ -583,7 +581,6 @@ static int new_lockspace(const char *name, int namelen, void **lockspace, dlm_create_debug_file(ls); log_debug(ls, "join complete"); - ret_zero: *lockspace = ls; return 0; @@ -628,7 +625,9 @@ int dlm_new_lockspace(const char *name, int namelen, void **lockspace, error = new_lockspace(name, namelen, lockspace, flags, lvblen); if (!error) ls_count++; - else if (!ls_count) + if (error > 0) + error = 0; + if (!ls_count) threads_stop(); out: mutex_unlock(&ls_lock); |