diff options
| author | Alexander Aring <aahringo@redhat.com> | 2021-03-01 23:05:14 +0100 |
|---|---|---|
| committer | David Teigland <teigland@redhat.com> | 2021-03-09 15:56:42 +0100 |
| commit | c45674fbdda138814ca21138475219c96fa5aa1f (patch) | |
| tree | 882c7102f75b410ed00941f244d6ad706fb4d026 /fs/dlm | |
| parent | fs: dlm: add check if dlm is currently running (diff) | |
| download | linux-c45674fbdda138814ca21138475219c96fa5aa1f.tar.xz linux-c45674fbdda138814ca21138475219c96fa5aa1f.zip | |
fs: dlm: change allocation limits
While running tcpkill I experienced invalid header length values while
receiving to check that a node doesn't try to send a invalid dlm message
we also check on applications minimum allocation limit. Also use
DEFAULT_BUFFER_SIZE as maximum allocation limit. The define
LOWCOMMS_MAX_TX_BUFFER_LEN is to calculate maximum buffer limits on
application layer, future midcomms layer will subtract their needs from
this define.
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
Diffstat (limited to 'fs/dlm')
| -rw-r--r-- | fs/dlm/lowcomms.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 4f2245e8677f..206bd30feb29 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -1376,9 +1376,11 @@ void *dlm_lowcomms_get_buffer(int nodeid, int len, gfp_t allocation, char **ppc) struct writequeue_entry *e; int offset = 0; - if (len > LOWCOMMS_MAX_TX_BUFFER_LEN) { - BUILD_BUG_ON(PAGE_SIZE < LOWCOMMS_MAX_TX_BUFFER_LEN); + if (len > DEFAULT_BUFFER_SIZE || + len < sizeof(struct dlm_header)) { + BUILD_BUG_ON(PAGE_SIZE < DEFAULT_BUFFER_SIZE); log_print("failed to allocate a buffer of size %d", len); + WARN_ON(1); return NULL; } |