diff options
| author | Gao Xiang <hsiangkao@redhat.com> | 2020-08-11 09:00:20 +0200 |
|---|---|---|
| committer | Gao Xiang <hsiangkao@redhat.com> | 2020-09-18 16:11:13 +0200 |
| commit | d578b46db69d125a654f509bdc9091d84e924dc8 (patch) | |
| tree | 0d21178a564d48eb191a9a43aa1747ea4e2d174a /fs/erofs | |
| parent | Linux 5.9-rc5 (diff) | |
| download | linux-d578b46db69d125a654f509bdc9091d84e924dc8.tar.xz linux-d578b46db69d125a654f509bdc9091d84e924dc8.zip | |
erofs: avoid duplicated permission check for "trusted." xattrs
Don't recheck it since xattr_permission() already
checks CAP_SYS_ADMIN capability.
Just follow 5d3ce4f70172 ("f2fs: avoid duplicated permission check for "trusted." xattrs")
Reported-by: Hongyu Jin <hongyu.jin@unisoc.com>
[ Gao Xiang: since it could cause some complex Android overlay
permission issue as well on android-5.4+, it'd be better to
backport to 5.4+ rather than pure cleanup on mainline. ]
Cc: <stable@vger.kernel.org> # 5.4+
Link: https://lore.kernel.org/r/20200811070020.6339-1-hsiangkao@redhat.com
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
Diffstat (limited to 'fs/erofs')
| -rw-r--r-- | fs/erofs/xattr.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/erofs/xattr.c b/fs/erofs/xattr.c index c8c381eadcd6..5bde77d70852 100644 --- a/fs/erofs/xattr.c +++ b/fs/erofs/xattr.c @@ -473,8 +473,6 @@ static int erofs_xattr_generic_get(const struct xattr_handler *handler, return -EOPNOTSUPP; break; case EROFS_XATTR_INDEX_TRUSTED: - if (!capable(CAP_SYS_ADMIN)) - return -EPERM; break; case EROFS_XATTR_INDEX_SECURITY: break; |