diff options
| author | Vladimir Zapolskiy <vladimir@tuxera.com> | 2020-01-02 13:01:16 +0100 |
|---|---|---|
| committer | Gao Xiang <gaoxiang25@huawei.com> | 2020-01-07 03:08:38 +0100 |
| commit | 997626d8383871862d0774c50a351aa98dacc0eb (patch) | |
| tree | 44383fdd7bbe1dfb1efff8686ec5cb48204fbd28 /fs/erofs | |
| parent | erofs: correct indentation of an assigned structure inside a function (diff) | |
| download | linux-997626d8383871862d0774c50a351aa98dacc0eb.tar.xz linux-997626d8383871862d0774c50a351aa98dacc0eb.zip | |
erofs: remove unused tag argument while finding a workgroup
It is feasible to simplify erofs_find_workgroup() interface by removing
an unused function argument. While formally the argument is used in the
function itself, its assigned value is ignored on the caller side.
Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
Link: https://lore.kernel.org/r/20200102120118.14979-2-vladimir@tuxera.com
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Diffstat (limited to 'fs/erofs')
| -rw-r--r-- | fs/erofs/internal.h | 2 | ||||
| -rw-r--r-- | fs/erofs/utils.c | 3 | ||||
| -rw-r--r-- | fs/erofs/zdata.c | 3 |
3 files changed, 3 insertions, 5 deletions
diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h index 1ed5beff7d11..c3d502b5fac7 100644 --- a/fs/erofs/internal.h +++ b/fs/erofs/internal.h @@ -401,7 +401,7 @@ static inline void *erofs_get_pcpubuf(unsigned int pagenr) #ifdef CONFIG_EROFS_FS_ZIP int erofs_workgroup_put(struct erofs_workgroup *grp); struct erofs_workgroup *erofs_find_workgroup(struct super_block *sb, - pgoff_t index, bool *tag); + pgoff_t index); int erofs_register_workgroup(struct super_block *sb, struct erofs_workgroup *grp, bool tag); void erofs_workgroup_free_rcu(struct erofs_workgroup *grp); diff --git a/fs/erofs/utils.c b/fs/erofs/utils.c index 1e8e1450d5b0..4d1cf4d00dab 100644 --- a/fs/erofs/utils.c +++ b/fs/erofs/utils.c @@ -59,7 +59,7 @@ repeat: } struct erofs_workgroup *erofs_find_workgroup(struct super_block *sb, - pgoff_t index, bool *tag) + pgoff_t index) { struct erofs_sb_info *sbi = EROFS_SB(sb); struct erofs_workgroup *grp; @@ -68,7 +68,6 @@ repeat: rcu_read_lock(); grp = radix_tree_lookup(&sbi->workstn_tree, index); if (grp) { - *tag = xa_pointer_tag(grp); grp = xa_untag_pointer(grp); if (erofs_workgroup_get(grp)) { diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c index ca99425a4536..052d28391ce6 100644 --- a/fs/erofs/zdata.c +++ b/fs/erofs/zdata.c @@ -345,9 +345,8 @@ static int z_erofs_lookup_collection(struct z_erofs_collector *clt, struct z_erofs_pcluster *pcl; struct z_erofs_collection *cl; unsigned int length; - bool tag; - grp = erofs_find_workgroup(inode->i_sb, map->m_pa >> PAGE_SHIFT, &tag); + grp = erofs_find_workgroup(inode->i_sb, map->m_pa >> PAGE_SHIFT); if (!grp) return -ENOENT; |