diff options
author | Zhen Lei <thunder.leizhen@huawei.com> | 2023-07-26 05:21:35 +0200 |
---|---|---|
committer | Christian Brauner <brauner@kernel.org> | 2023-07-26 14:56:07 +0200 |
commit | 05f26f86f4a1f31d5ed2015ac1c89ea9da1d2bb7 (patch) | |
tree | 45fe87db01c99be821bf9fe2c8d3764a63d119f2 /fs/eventpoll.c | |
parent | fs: Fix error checking for d_hash_and_lookup() (diff) | |
download | linux-05f26f86f4a1f31d5ed2015ac1c89ea9da1d2bb7.tar.xz linux-05f26f86f4a1f31d5ed2015ac1c89ea9da1d2bb7.zip |
epoll: simplify ep_alloc()
The get_current_user() does not fail, and moving it after kzalloc() can
simplify the code a bit.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Message-Id: <20230726032135.933-1-thunder.leizhen@huaweicloud.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to '')
-rw-r--r-- | fs/eventpoll.c | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 4b1b3362f697..1d9a71a0c4c1 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -975,15 +975,11 @@ again: static int ep_alloc(struct eventpoll **pep) { - int error; - struct user_struct *user; struct eventpoll *ep; - user = get_current_user(); - error = -ENOMEM; ep = kzalloc(sizeof(*ep), GFP_KERNEL); if (unlikely(!ep)) - goto free_uid; + return -ENOMEM; mutex_init(&ep->mtx); rwlock_init(&ep->lock); @@ -992,16 +988,12 @@ static int ep_alloc(struct eventpoll **pep) INIT_LIST_HEAD(&ep->rdllist); ep->rbr = RB_ROOT_CACHED; ep->ovflist = EP_UNACTIVE_PTR; - ep->user = user; + ep->user = get_current_user(); refcount_set(&ep->refcount, 1); *pep = ep; return 0; - -free_uid: - free_uid(user); - return error; } /* |