diff options
| author | Oleg Nesterov <oleg@tv-sign.ru> | 2008-07-25 10:47:39 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-25 19:53:39 +0200 |
| commit | 15b9f360c0316c06d37c09b02d85565edbaf9dd3 (patch) | |
| tree | 5e874b98b6f16ca1f376f5e4bd480da7ae5143b6 /fs/exec.c | |
| parent | kill PF_BORROWED_MM in favour of PF_KTHREAD (diff) | |
| download | linux-15b9f360c0316c06d37c09b02d85565edbaf9dd3.tar.xz linux-15b9f360c0316c06d37c09b02d85565edbaf9dd3.zip | |
coredump: zap_threads() must skip kernel threads
The main loop in zap_threads() must skip kthreads which may use the same
mm. Otherwise we "kill" this thread erroneously (for example, it can not
fork or exec after that), and the coredumping task stucks in the
TASK_UNINTERRUPTIBLE state forever because of the wrong ->core_waiters
count.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/exec.c')
| -rw-r--r-- | fs/exec.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/exec.c b/fs/exec.c index cd2e8c9b1249..e347e6ed1617 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -1574,11 +1574,12 @@ static inline int zap_threads(struct task_struct *tsk, struct mm_struct *mm, for_each_process(g) { if (g == tsk->group_leader) continue; - + if (g->flags & PF_KTHREAD) + continue; p = g; do { if (p->mm) { - if (p->mm == mm) { + if (unlikely(p->mm == mm)) { lock_task_sighand(p, &flags); zap_process(p); unlock_task_sighand(p, &flags); |