diff options
| author | Miklos Szeredi <mszeredi@suse.cz> | 2007-10-17 08:27:08 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-17 17:42:52 +0200 |
| commit | 22590e41cb569add194829c08dc0ceea74b38a65 (patch) | |
| tree | 0db73fe0e78bcde816dcf289e0aa5323abf73833 /fs/exec.c | |
| parent | VFS: check nanoseconds in utimensat (diff) | |
| download | linux-22590e41cb569add194829c08dc0ceea74b38a65.tar.xz linux-22590e41cb569add194829c08dc0ceea74b38a65.zip | |
fix execute checking in permission()
permission() checks that MAY_EXEC is only allowed on regular files if at least
one execute bit is set in the file mode.
generic_permission() already ensures this, so the extra check in permission()
is superfluous.
If the filesystem defines it's own ->permission() the check may still be
needed. In this case move it after ->permission(). This is needed because
filesystems such as FUSE may need to refresh the inode attributes before
checking permissions.
This check should be moved inside ->permission(), but that's another story.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/exec.c')
0 files changed, 0 insertions, 0 deletions