diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2018-05-17 23:18:30 +0200 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2018-05-21 20:30:11 +0200 |
| commit | 5aa1437d2d9a068c0334bd7c9dafa8ec4f97f13b (patch) | |
| tree | 1f8e9a78b800f50fef4277a7971415c1412fb6c4 /fs/ext2/inode.c | |
| parent | nfsd: vfs_mkdir() might succeed leaving dentry negative unhashed (diff) | |
| download | linux-5aa1437d2d9a068c0334bd7c9dafa8ec4f97f13b.tar.xz linux-5aa1437d2d9a068c0334bd7c9dafa8ec4f97f13b.zip | |
ext2: fix a block leak
open file, unlink it, then use ioctl(2) to make it immutable or
append only. Now close it and watch the blocks *not* freed...
Immutable/append-only checks belong in ->setattr().
Note: the bug is old and backport to anything prior to 737f2e93b972
("ext2: convert to use the new truncate convention") will need
these checks lifted into ext2_setattr().
Cc: stable@kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ext2/inode.c')
| -rw-r--r-- | fs/ext2/inode.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 1e01fabef130..71635909df3b 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -1264,21 +1264,11 @@ do_indirects: static void ext2_truncate_blocks(struct inode *inode, loff_t offset) { - /* - * XXX: it seems like a bug here that we don't allow - * IS_APPEND inode to have blocks-past-i_size trimmed off. - * review and fix this. - * - * Also would be nice to be able to handle IO errors and such, - * but that's probably too much to ask. - */ if (!(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode))) return; if (ext2_inode_is_fast_symlink(inode)) return; - if (IS_APPEND(inode) || IS_IMMUTABLE(inode)) - return; dax_sem_down_write(EXT2_I(inode)); __ext2_truncate_blocks(inode, offset); |