diff options
| author | Jan Kara <jack@suse.cz> | 2012-03-31 14:22:10 +0200 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2012-04-11 11:12:45 +0200 |
| commit | b838ec2232b764a4903707e212c62f681b32cd51 (patch) | |
| tree | 31967c9821f019d97fdb6882a0b31d41db3d10e5 /fs/ext2/xattr.c | |
| parent | ext2: write superblock only once on unmount (diff) | |
| download | linux-b838ec2232b764a4903707e212c62f681b32cd51.tar.xz linux-b838ec2232b764a4903707e212c62f681b32cd51.zip | |
ext2: Remove s_dirt handling
Places which modify superblock feature / state fields mark the superblock
buffer dirty so it is written out by flusher thread. Thus there's no need to
set s_dirt there.
The only other fields changing in the superblock are the numbers of free
blocks, free inodes and s_wtime. There's no real need to write (or even
compute) these periodically. Free blocks / inodes counters are recomputed on
every mount from group counters anyway and value of s_wtime is only
informational and imprecise anyway. So it should be enough to write these
opportunistically on mount, remount, umount, and sync_fs times.
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to '')
| -rw-r--r-- | fs/ext2/xattr.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c index 6dcafc7efdfd..b6754dbbce3c 100644 --- a/fs/ext2/xattr.c +++ b/fs/ext2/xattr.c @@ -339,7 +339,6 @@ static void ext2_xattr_update_super_block(struct super_block *sb) spin_lock(&EXT2_SB(sb)->s_lock); EXT2_SET_COMPAT_FEATURE(sb, EXT2_FEATURE_COMPAT_EXT_ATTR); spin_unlock(&EXT2_SB(sb)->s_lock); - sb->s_dirt = 1; mark_buffer_dirty(EXT2_SB(sb)->s_sbh); } |