summaryrefslogtreecommitdiffstats
path: root/fs/ext2
diff options
context:
space:
mode:
authorMing Lei <ming.lei@canonical.com>2013-03-20 16:25:25 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-03-21 00:53:42 +0100
commite5110f411d2ee35bf8d202ccca2e89c633060dca (patch)
tree9fe7297901679cca05b459f9e7e524e99c534a7d /fs/ext2
parentsysfs: fix race between readdir and lseek (diff)
downloadlinux-e5110f411d2ee35bf8d202ccca2e89c633060dca.tar.xz
linux-e5110f411d2ee35bf8d202ccca2e89c633060dca.zip
sysfs: handle failure path correctly for readdir()
In case of 'if (filp->f_pos == 0 or 1)' of sysfs_readdir(), the failure from filldir() isn't handled, and the reference counter of the sysfs_dirent object pointed by filp->private_data will be released without clearing filp->private_data, so use after free bug will be triggered later. This patch returns immeadiately under the situation for fixing the bug, and it is reasonable to return from readdir() when filldir() fails. Reported-by: Dave Jones <davej@redhat.com> Tested-by: Sasha Levin <levinsasha928@gmail.com> Cc: <stable@vger.kernel.org> Signed-off-by: Ming Lei <ming.lei@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/ext2')
0 files changed, 0 insertions, 0 deletions