diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2008-08-01 10:29:18 +0200 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2008-08-01 17:25:25 +0200 |
| commit | 77e69dac3cefacee939cb107ae9cd520a62338e0 (patch) | |
| tree | 02ddee5ac85ceb632eab2aff994ffbd3233e51eb /fs/ext3 | |
| parent | [PATCH] clean dup2() up a bit (diff) | |
| download | linux-77e69dac3cefacee939cb107ae9cd520a62338e0.tar.xz linux-77e69dac3cefacee939cb107ae9cd520a62338e0.zip | |
[PATCH] fix races and leaks in vfs_quota_on() users
* new helper: vfs_quota_on_path(); equivalent of vfs_quota_on() sans the
pathname resolution.
* callers of vfs_quota_on() that do their own pathname resolution and
checks based on it are switched to vfs_quota_on_path(); that way we
avoid the races.
* reiserfs leaked dentry/vfsmount references on several failure exits.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ext3')
| -rw-r--r-- | fs/ext3/super.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 8ddced384674..f38a5afc39a1 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c @@ -2810,8 +2810,9 @@ static int ext3_quota_on(struct super_block *sb, int type, int format_id, journal_unlock_updates(EXT3_SB(sb)->s_journal); } + err = vfs_quota_on_path(sb, type, format_id, &nd.path); path_put(&nd.path); - return vfs_quota_on(sb, type, format_id, path, remount); + return err; } /* Read data from quotafile - avoid pagecache and such because we cannot afford |