diff options
| author | Eugene Shatokhin <eugene.shatokhin@rosalab.ru> | 2012-11-08 21:11:11 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2012-11-08 21:11:11 +0100 |
| commit | 24ec19b0ae83a385ad9c55520716da671274b96c (patch) | |
| tree | ecb244d45bac1c8839c9a724b4045e7dfdf111c7 /fs/ext4/acl.c | |
| parent | ext4: remove code duplication in ext4_get_block_write_nolock() (diff) | |
| download | linux-24ec19b0ae83a385ad9c55520716da671274b96c.tar.xz linux-24ec19b0ae83a385ad9c55520716da671274b96c.zip | |
ext4: fix memory leak in ext4_xattr_set_acl()'s error path
In ext4_xattr_set_acl(), if ext4_journal_start() returns an error,
posix_acl_release() will not be called for 'acl' which may result in a
memory leak.
This patch fixes that.
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Eugene Shatokhin <eugene.shatokhin@rosalab.ru>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
Diffstat (limited to 'fs/ext4/acl.c')
| -rw-r--r-- | fs/ext4/acl.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/ext4/acl.c b/fs/ext4/acl.c index d3c5b88fd89f..e6e0d988439b 100644 --- a/fs/ext4/acl.c +++ b/fs/ext4/acl.c @@ -423,8 +423,10 @@ ext4_xattr_set_acl(struct dentry *dentry, const char *name, const void *value, retry: handle = ext4_journal_start(inode, EXT4_DATA_TRANS_BLOCKS(inode->i_sb)); - if (IS_ERR(handle)) - return PTR_ERR(handle); + if (IS_ERR(handle)) { + error = PTR_ERR(handle); + goto release_and_out; + } error = ext4_set_acl(handle, inode, type, acl); ext4_journal_stop(handle); if (error == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries)) |