diff options
author | Michal Hocko <mhocko@suse.cz> | 2015-06-08 16:53:10 +0200 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2015-06-08 16:53:10 +0200 |
commit | 6ccaf3e2f302b6af8d9e17ce4e7f0af26b6baa0e (patch) | |
tree | cc3a37a205d0fc980ff9e9788daf9526a0976532 /fs/ext4/balloc.c | |
parent | ext4 crypto: allocate bounce pages using GFP_NOWAIT (diff) | |
download | linux-6ccaf3e2f302b6af8d9e17ce4e7f0af26b6baa0e.tar.xz linux-6ccaf3e2f302b6af8d9e17ce4e7f0af26b6baa0e.zip |
jbd2: revert must-not-fail allocation loops back to GFP_NOFAIL
This basically reverts 47def82672b3 (jbd2: Remove __GFP_NOFAIL from jbd2
layer). The deprecation of __GFP_NOFAIL was a bad choice because it led
to open coding the endless loop around the allocator rather than
removing the dependency on the non failing allocation. So the
deprecation was a clear failure and the reality tells us that
__GFP_NOFAIL is not even close to go away.
It is still true that __GFP_NOFAIL allocations are generally discouraged
and new uses should be evaluated and an alternative (pre-allocations or
reservations) should be considered but it doesn't make any sense to lie
the allocator about the requirements. Allocator can take steps to help
making a progress if it knows the requirements.
Signed-off-by: Michal Hocko <mhocko@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Acked-by: David Rientjes <rientjes@google.com>
Diffstat (limited to 'fs/ext4/balloc.c')
0 files changed, 0 insertions, 0 deletions