diff options
| author | Stefan Behrens <sbehrens@giantdisaster.de> | 2012-08-10 16:58:21 +0200 |
|---|---|---|
| committer | Chris Mason <chris.mason@oracle.com> | 2012-08-28 22:53:43 +0200 |
| commit | 256dd1bb3750ac5ad49b40887c1691788dc44b33 (patch) | |
| tree | d260aa607397dd2e67681b4b264585be3032e9d9 /fs/ext4/bitmap.c | |
| parent | Btrfs: fix ordered extent leak when failing to start a transaction (diff) | |
| download | linux-256dd1bb3750ac5ad49b40887c1691788dc44b33.tar.xz linux-256dd1bb3750ac5ad49b40887c1691788dc44b33.zip | |
Btrfs: fix that repair code is spuriously executed for transid failures
If verify_parent_transid() fails for all mirrors, the current code
calls repair_io_failure() anyway which means:
- that the disk block is rewritten without repairing anything and
- that a kernel log message is printed which misleadingly claims
that a read error was corrected.
This is an example:
parent transid verify failed on 615015833600 wanted 110423 found 110424
parent transid verify failed on 615015833600 wanted 110423 found 110424
btrfs read error corrected: ino 1 off 615015833600 (dev /dev/...)
It is wrong to ignore the results from verify_parent_transid() and to
call repair_eb_io_failure() when the verification of the transids failed.
This commit fixes the issue.
Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
Diffstat (limited to 'fs/ext4/bitmap.c')
0 files changed, 0 insertions, 0 deletions