diff options
| author | Ye Bin <yebin10@huawei.com> | 2022-09-21 08:40:38 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2022-10-01 05:46:54 +0200 |
| commit | 9305721a309fa1bd7c194e0d4a2335bf3b29dca4 (patch) | |
| tree | c16ee6ef574bf837ecff1352e3c93aef0694b559 /fs/ext4/fast_commit.c | |
| parent | ext4: remove redundant checking in ext4_ioctl_checkpoint (diff) | |
| download | linux-9305721a309fa1bd7c194e0d4a2335bf3b29dca4.tar.xz linux-9305721a309fa1bd7c194e0d4a2335bf3b29dca4.zip | |
ext4: fix potential memory leak in ext4_fc_record_modified_inode()
As krealloc may return NULL, in this case 'state->fc_modified_inodes'
may not be freed by krealloc, but 'state->fc_modified_inodes' already
set NULL. Then will lead to 'state->fc_modified_inodes' memory leak.
Cc: stable@kernel.org
Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220921064040.3693255-2-yebin10@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to '')
| -rw-r--r-- | fs/ext4/fast_commit.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c index 9217a588afd1..9555ab816d7d 100644 --- a/fs/ext4/fast_commit.c +++ b/fs/ext4/fast_commit.c @@ -1486,13 +1486,15 @@ static int ext4_fc_record_modified_inode(struct super_block *sb, int ino) if (state->fc_modified_inodes[i] == ino) return 0; if (state->fc_modified_inodes_used == state->fc_modified_inodes_size) { - state->fc_modified_inodes = krealloc( - state->fc_modified_inodes, + int *fc_modified_inodes; + + fc_modified_inodes = krealloc(state->fc_modified_inodes, sizeof(int) * (state->fc_modified_inodes_size + EXT4_FC_REPLAY_REALLOC_INCREMENT), GFP_KERNEL); - if (!state->fc_modified_inodes) + if (!fc_modified_inodes) return -ENOMEM; + state->fc_modified_inodes = fc_modified_inodes; state->fc_modified_inodes_size += EXT4_FC_REPLAY_REALLOC_INCREMENT; } |