diff options
| author | Jan Kara <jack@suse.cz> | 2012-07-23 02:29:31 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2012-07-23 02:29:31 +0200 |
| commit | 97a7406880f61d7f89d613cf72e87682420e66b0 (patch) | |
| tree | cb6a314383e5279718eaa66c6d549d90e85aee99 /fs/ext4/ialloc.c | |
| parent | ext4: fix ext4 mismerge back in January (diff) | |
| download | linux-97a7406880f61d7f89d613cf72e87682420e66b0.tar.xz linux-97a7406880f61d7f89d613cf72e87682420e66b0.zip | |
ext4: remove useless marking of superblock dirty
Commit a0375156 properly notes that superblock doesn't need to be marked
as dirty when only number of free inodes / blocks / number of directories
changes since that is recomputed on each mount anyway. However that comment
leaves some unnecessary markings as dirty in place. Remove these.
Artem: tested using xfstests for both journalled and non-journalled ext4.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Tested-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Diffstat (limited to 'fs/ext4/ialloc.c')
| -rw-r--r-- | fs/ext4/ialloc.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index 6866bc233e94..26154b81b836 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -315,7 +315,6 @@ out: err = ext4_handle_dirty_metadata(handle, NULL, bitmap_bh); if (!fatal) fatal = err; - ext4_mark_super_dirty(sb); } else ext4_error(sb, "bit already cleared for inode %lu", ino); @@ -830,7 +829,6 @@ got: percpu_counter_dec(&sbi->s_freeinodes_counter); if (S_ISDIR(mode)) percpu_counter_inc(&sbi->s_dirs_counter); - ext4_mark_super_dirty(sb); if (sbi->s_log_groups_per_flex) { flex_group = ext4_flex_group(sbi, group); |