diff options
| author | Maurizio Lombardi <mlombard@redhat.com> | 2018-12-04 06:06:53 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2018-12-04 06:06:53 +0100 |
| commit | 132d00becb31e88469334e1e62751c81345280e0 (patch) | |
| tree | d9c9ce5fd0e3cfe49b3fa9d068ce2a1215e37985 /fs/ext4/inline.c | |
| parent | ext4: fix possible use after free in ext4_quota_enable (diff) | |
| download | linux-132d00becb31e88469334e1e62751c81345280e0.tar.xz linux-132d00becb31e88469334e1e62751c81345280e0.zip | |
ext4: missing unlock/put_page() in ext4_try_to_write_inline_data()
In case of error, ext4_try_to_write_inline_data() should unlock
and release the page it holds.
Fixes: f19d5870cbf7 ("ext4: add normal write support for inline data")
Cc: stable@kernel.org # 3.8
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/inline.c')
| -rw-r--r-- | fs/ext4/inline.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index 9c4bac18cc6c..27373d88b5f0 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -705,8 +705,11 @@ int ext4_try_to_write_inline_data(struct address_space *mapping, if (!PageUptodate(page)) { ret = ext4_read_inline_page(inode, page); - if (ret < 0) + if (ret < 0) { + unlock_page(page); + put_page(page); goto out_up_read; + } } ret = 1; |