summaryrefslogtreecommitdiffstats
path: root/fs/ext4/inode.c
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2013-06-04 18:56:55 +0200
committerTheodore Ts'o <tytso@mit.edu>2013-06-04 18:56:55 +0200
commitfa55a0ed0386e1fcbb8a229a06a5c70477d0d6e5 (patch)
tree8b1abbd432fd799ff7d537851d758c0a7b1e26a8 /fs/ext4/inode.c
parentext4: deprecate max_writeback_mb_bump sysfs attribute (diff)
downloadlinux-fa55a0ed0386e1fcbb8a229a06a5c70477d0d6e5.tar.xz
linux-fa55a0ed0386e1fcbb8a229a06a5c70477d0d6e5.zip
ext4: improve writepage credit estimate for files with indirect blocks
ext4_ind_trans_blocks() wrongly used 'chunk' argument to decide whether blocks mapped are logically contiguous. That is wrong since the argument informs whether the blocks are physically contiguous. As the blocks mapped are always logically contiguous and that's all ext4_ind_trans_blocks() cares about, just remove the 'chunk' argument. Reviewed-by: Zheng Liu <wenqing.lz@taobao.com> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/inode.c')
-rw-r--r--fs/ext4/inode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 80c710ae470b..23d9a44d721a 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -4653,7 +4653,7 @@ int ext4_getattr(struct vfsmount *mnt, struct dentry *dentry,
static int ext4_index_trans_blocks(struct inode *inode, int nrblocks, int chunk)
{
if (!(ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)))
- return ext4_ind_trans_blocks(inode, nrblocks, chunk);
+ return ext4_ind_trans_blocks(inode, nrblocks);
return ext4_ext_index_trans_blocks(inode, nrblocks, chunk);
}